<html>
<head><meta charset="utf-8"><title>Task list for reenabling incr-comp on stable · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Task.20list.20for.20reenabling.20incr-comp.20on.20stable.html">Task list for reenabling incr-comp on stable</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="247356754"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Task%20list%20for%20reenabling%20incr-comp%20on%20stable/near/247356754" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Task.20list.20for.20reenabling.20incr-comp.20on.20stable.html#247356754">(Jul 27 2021 at 16:26)</a>:</h4>
<p>Hey <span class="user-mention" data-user-id="125250">@Wesley Wiser</span> , I just wanted to check in: The main task remaining related to incr-comp for the 1.54.0 release is something in the release notes providing some context from the POV of the compiler-team about is happening and what we want from our user base, Right? I think <span class="user-mention" data-user-id="119031">@Esteban Küber</span> had volunteered to help write (or at least review) such text, but I don’t think they’ll be available to do so now.</p>



<a name="247356853"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Task%20list%20for%20reenabling%20incr-comp%20on%20stable/near/247356853" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Task.20list.20for.20reenabling.20incr-comp.20on.20stable.html#247356853">(Jul 27 2021 at 16:27)</a>:</h4>
<p>I wrote a section for the release notes yesterday but haven't gotten any feedback yet: <a href="https://github.com/rust-lang/blog.rust-lang.org/pull/870#discussion_r676916623">https://github.com/rust-lang/blog.rust-lang.org/pull/870#discussion_r676916623</a></p>



<a name="247356869"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Task%20list%20for%20reenabling%20incr-comp%20on%20stable/near/247356869" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Task.20list.20for.20reenabling.20incr-comp.20on.20stable.html#247356869">(Jul 27 2021 at 16:28)</a>:</h4>
<p>ah yes, you even had dialogue about it over on T-release, just <a href="#narrow/stream/241545-t-release/topic/1.2E54.20release/near/247198560">found the comment</a></p>



<a name="247356925"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Task%20list%20for%20reenabling%20incr-comp%20on%20stable/near/247356925" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Task.20list.20for.20reenabling.20incr-comp.20on.20stable.html#247356925">(Jul 27 2021 at 16:28)</a>:</h4>
<p>I’ll go look at it now.</p>



<a name="247356993"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Task%20list%20for%20reenabling%20incr-comp%20on%20stable/near/247356993" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Task.20list.20for.20reenabling.20incr-comp.20on.20stable.html#247356993">(Jul 27 2021 at 16:28)</a>:</h4>
<p>Looking and commenting</p>



<a name="247357068"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Task%20list%20for%20reenabling%20incr-comp%20on%20stable/near/247357068" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Task.20list.20for.20reenabling.20incr-comp.20on.20stable.html#247357068">(Jul 27 2021 at 16:29)</a>:</h4>
<p>heh. Hard to comment on it since it isn’t commited yet</p>



<a name="247357103"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Task%20list%20for%20reenabling%20incr-comp%20on%20stable/near/247357103" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Task.20list.20for.20reenabling.20incr-comp.20on.20stable.html#247357103">(Jul 27 2021 at 16:29)</a>:</h4>
<p>(can’t do 2nd order derivatives; i.e. no deltas of deltas, heh…)</p>



<a name="247358225"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Task%20list%20for%20reenabling%20incr-comp%20on%20stable/near/247358225" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Task.20list.20for.20reenabling.20incr-comp.20on.20stable.html#247358225">(Jul 27 2021 at 16:39)</a>:</h4>
<p>Commented, one nitpick and mainly one sentence added (and smaller tweaks).</p>



<a name="247358266"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Task%20list%20for%20reenabling%20incr-comp%20on%20stable/near/247358266" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Task.20list.20for.20reenabling.20incr-comp.20on.20stable.html#247358266">(Jul 27 2021 at 16:39)</a>:</h4>
<p>The new sentence about crash reporting is something I want included, in one shape or another.</p>



<a name="247358358"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Task%20list%20for%20reenabling%20incr-comp%20on%20stable/near/247358358" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Task.20list.20for.20reenabling.20incr-comp.20on.20stable.html#247358358">(Jul 27 2021 at 16:40)</a>:</h4>
<p>I think <span class="user-mention" data-user-id="119031">@Esteban Küber</span> ’s points are very good</p>



<a name="247358697"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Task%20list%20for%20reenabling%20incr-comp%20on%20stable/near/247358697" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Task.20list.20for.20reenabling.20incr-comp.20on.20stable.html#247358697">(Jul 27 2021 at 16:43)</a>:</h4>
<p><span class="user-mention" data-user-id="125250">@Wesley Wiser</span> <span class="user-mention" data-user-id="119031">@Esteban Küber</span> is it worth pointing out that if the error occurs, its diagnostic now includes additional information about what the user should take in response?</p>



<a name="247358795"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Task%20list%20for%20reenabling%20incr-comp%20on%20stable/near/247358795" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Task.20list.20for.20reenabling.20incr-comp.20on.20stable.html#247358795">(Jul 27 2021 at 16:43)</a>:</h4>
<p>i.e., since we’re already admitting that issues persist: In addition to saying that they are hopefully rare, we can also state that the UX is much better than it was in 1.52.0 ?</p>



<a name="247358948"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Task%20list%20for%20reenabling%20incr-comp%20on%20stable/near/247358948" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Task.20list.20for.20reenabling.20incr-comp.20on.20stable.html#247358948">(Jul 27 2021 at 16:44)</a>:</h4>
<p>(I know the UX improvements were present in 1.52.1. But since most people didn’t re-enable incr-comp via the env var opt-in, I think its worth treating it like a “new thing” for stable in 1.54.0…)</p>



<a name="247359724"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Task%20list%20for%20reenabling%20incr-comp%20on%20stable/near/247359724" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Task.20list.20for.20reenabling.20incr-comp.20on.20stable.html#247359724">(Jul 27 2021 at 16:50)</a>:</h4>
<p>Sure, I can add that!</p>



<a name="247359739"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Task%20list%20for%20reenabling%20incr-comp%20on%20stable/near/247359739" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Task.20list.20for.20reenabling.20incr-comp.20on.20stable.html#247359739">(Jul 27 2021 at 16:50)</a>:</h4>
<p>Thanks both of you for taking a look!</p>



<a name="247359850"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Task%20list%20for%20reenabling%20incr-comp%20on%20stable/near/247359850" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Task.20list.20for.20reenabling.20incr-comp.20on.20stable.html#247359850">(Jul 27 2021 at 16:51)</a>:</h4>
<p><span class="user-mention" data-user-id="125250">@Wesley Wiser</span> fyi - I just accepted <span class="user-mention" data-user-id="119031">@Esteban Küber</span>'s text so that we can get <em>something</em> in, but I am open to patches onto it</p>



<a name="247359922"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Task%20list%20for%20reenabling%20incr-comp%20on%20stable/near/247359922" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Task.20list.20for.20reenabling.20incr-comp.20on.20stable.html#247359922">(Jul 27 2021 at 16:52)</a>:</h4>
<p>(reviewing without diffs can be a little hard)</p>



<a name="247359948"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Task%20list%20for%20reenabling%20incr-comp%20on%20stable/near/247359948" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Task.20list.20for.20reenabling.20incr-comp.20on.20stable.html#247359948">(Jul 27 2021 at 16:52)</a>:</h4>
<p>That's helpful, thanks <span class="user-mention" data-user-id="116122">@simulacrum</span></p>



<a name="247360090"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Task%20list%20for%20reenabling%20incr-comp%20on%20stable/near/247360090" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Task.20list.20for.20reenabling.20incr-comp.20on.20stable.html#247360090">(Jul 27 2021 at 16:53)</a>:</h4>
<p>Mentioning the new output is a good choice. Likely not needed to explain what the error looks like or the solution, which appears in the error, right?</p>



<a name="247360184"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Task%20list%20for%20reenabling%20incr-comp%20on%20stable/near/247360184" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Task.20list.20for.20reenabling.20incr-comp.20on.20stable.html#247360184">(Jul 27 2021 at 16:54)</a>:</h4>
<p>Or maybe show the snippet so if people see it they can identify it faster <span aria-label="thinking" class="emoji emoji-1f914" role="img" title="thinking">:thinking:</span></p>



<a name="247360196"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Task%20list%20for%20reenabling%20incr-comp%20on%20stable/near/247360196" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Task.20list.20for.20reenabling.20incr-comp.20on.20stable.html#247360196">(Jul 27 2021 at 16:54)</a>:</h4>
<p>I can see both positions <span aria-label="blush" class="emoji emoji-1f60a" role="img" title="blush">:blush:</span></p>



<a name="247361609"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Task%20list%20for%20reenabling%20incr-comp%20on%20stable/near/247361609" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Task.20list.20for.20reenabling.20incr-comp.20on.20stable.html#247361609">(Jul 27 2021 at 17:04)</a>:</h4>
<p>I think it would be useful to include it</p>



<a name="247417063"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Task%20list%20for%20reenabling%20incr-comp%20on%20stable/near/247417063" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Task.20list.20for.20reenabling.20incr-comp.20on.20stable.html#247417063">(Jul 28 2021 at 03:05)</a>:</h4>
<p>Added a basic example, <a href="https://github.com/rust-lang/blog.rust-lang.org/pull/870#discussion_r677938869">https://github.com/rust-lang/blog.rust-lang.org/pull/870#discussion_r677938869</a>. Let me know what you all think.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>